Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip][SRVKS-1301][RELEASE-1.35] Wait for deployments #3484

Closed
wants to merge 1 commit into from
Closed

[wip][SRVKS-1301][RELEASE-1.35] Wait for deployments #3484

wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Mar 5, 2025 •
edited
Loading

Fixes JIRA #SRVKS-1301

Proposed Changes

  • Waits for deployments that exists in the current manifest before applying the new webhook configurations and the dependent resources. Eliminates the error during the reconciliation phase described in the ticket.
  • I will check if the error happens with the upstream operator too. If so I will push this upstream to get some feedback.
  • I will create a PR on main too, to test upgrades

@openshift-ci openshift-ci bot requested review from creydr and mgencur March 5, 2025 20:36
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2025
@skonto skonto mentioned this pull request Mar 5, 2025
Closed
skonto
skonto commented Mar 5, 2025
View reviewed changes
vendor/knative.dev/operator/pkg/reconciler/common/deployments.go
@@ -52,7 +54,7 @@ func CheckDeployments(ctx context.Context, manifest *mf.Manifest, instance base.

if len(nonReadyDeployments) > 0 {
status.MarkDeploymentsNotReady(nonReadyDeployments)
return nil
return controller.NewRequeueAfter(5*time.Second)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be lowered. This forces to reconcile again and make things a bit stricter.

@skonto skonto requested review from dsimansk and removed request for mgencur and creydr March 5, 2025 20:39
@skonto skonto assigned skonto and dsimansk and unassigned skonto Mar 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-test-upgrade-aws-417 571794b link true /test 417-test-upgrade-aws-417

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skonto
Copy link
Contributor Author

skonto commented Mar 6, 2025

The transient error exists also at the upstream operator I will try fix it there first.

@skonto
Copy link
Contributor Author

skonto commented Mar 10, 2025

Closing as there is work upstream: knative/operator#2010.

@skonto skonto closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @dsimansk